Add GCS wildcard import support #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daku10 Thank you for your awesome PR !!! Sorry for the late reply, LGTM 👍 |
diogogmt
pushed a commit
to blockthrough/bigquery-emulator
that referenced
this pull request
Sep 20, 2023
Add GCS wildcard import support
diogogmt
pushed a commit
to blockthrough/bigquery-emulator
that referenced
this pull request
Sep 20, 2023
Add GCS wildcard import support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you for this great project.
I've implemented load from GCS with wildcard.
To my understanding, GCS ListObjectAPI has several options, but doesn't handle wildcard directly.
Therefore I investigated gsutil which has wildcard list functionality, it seems
gsutilparse wildcards by itself (I'm not familiar with python, I'm sorry if I'm wrong)Hence, I've implemented handling wildcard simply, because the wildcard support is limited(at most one asterisk is allowed).
ref
Go SDK ListObjects