fix handling of empty/null arrays #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmerken
changed the title
|
Would like to see this merged, it also fixes the issue we are currently facing where having an empty array in the test data causes |
isamert
pushed a commit
to isamert/bigquery-emulator
that referenced
this pull request
Oct 30, 2023
isamert
added a commit
to isamert/bigquery-emulator
that referenced
this pull request
Oct 30, 2023
|
@goccy can you consider merge that fix? currently is not possible to query data that have fields with empty array |
goccy
reviewed
Dec 7, 2023
| @@ -315,8 +319,8 @@ func (r *Repository) convertValueToCell(value interface{}) (*internaltypes.Table | |||
| } | |||
| // array type | |||
| var ( | |||
| cells []*internaltypes.TableCell | |||
There was a problem hiding this comment.
nits: These initialization operation is not required
|
LGTM 👍 ( We need to add linter ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #238