fix: change isPtr to true on listElemCode #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 79.93% 79.94% +0.01%
==========================================
Files 52 52
Lines 17565 17576 +11
==========================================
+ Hits 14040 14051 +11
Misses 2957 2957
Partials 568 568 |
goccy
reviewed
Jul 5, 2022
| @@ -487,7 +487,7 @@ func (c *Compiler) listElemCode(typ *runtime.Type) (Code, error) { | |||
| case typ.Kind() == reflect.Map: | |||
| return c.ptrCode(runtime.PtrTo(typ)) | |||
| default: | |||
| code, err := c.typeToCodeWithPtr(typ, false) | |||
| code, err := c.typeToCodeWithPtr(typ, true) | |||
There was a problem hiding this comment.
Hmm..., I feel that the fix to set isPtr to true is not correct to fix this issue (
since elem is not ptr type )
There was a problem hiding this comment.
I added a comment!
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #370