Update formatPatternMap to correctly interpret %u
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goccy
requested changes
Dec 7, 2023
internal/function_time_parser.go
Outdated
| @@ -416,6 +416,10 @@ func weekOfDayFormatter(t *time.Time) ([]rune, error) { | |||
| return []rune(dayOfWeeks[int(t.Weekday())]), nil | |||
| } | |||
|
|
|||
| func weekOfDayNumberFormatter(t *time.Time) ([]rune, error) { | |||
| return []rune(fmt.Sprintf("%d", int(t.Weekday()))), nil | |||
There was a problem hiding this comment.
please use []rune(fmt.Sprint(int(t.Weekday())))
philschoefer
force-pushed
the
fix-u-format
branch
from
22bc655 to
a6274e6
Compare
|
Thank you! Updated, please re-review ❤️ |
ohaibbq
suggested changes
Jan 26, 2024
| @@ -416,6 +416,10 @@ func weekOfDayFormatter(t *time.Time) ([]rune, error) { | |||
| return []rune(dayOfWeeks[int(t.Weekday())]), nil | |||
| } | |||
|
|
|||
| func weekOfDayNumberFormatter(t *time.Time) ([]rune, error) { | |||
| return []rune(fmt.Sprint(int(t.Weekday()))) | |||
There was a problem hiding this comment.
Thanks for the update @philschoefer
It looks like the build is failing as you're no longer returning a nil error
By the way, I'm not a project member, so I won't have permission to approve / get this merged.
We'll need to wait for @goccy
|
Due to lack of response, this PR is closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #125
Summary of problem:
When using something like
FORMAT_TIMESTAMP('%u', sale_happened_at)it currently returns the week number of the current year (e.g.43).According to the BigQuery docs this should return the number of the week day instead (starting at
0forSunday).(possible) cause
It looks like this is simply calling the wrong function.
Changes made in this PR:
I created a new function to return the number and added a test.
Thank you for considering this merge!