[Windowing] Handle multiple sort expressions #142
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 45.82% 45.81% -0.01%
==========================================
Files 47 47
Lines 17800 17801 +1
==========================================
- Hits 8156 8155 -1
- Misses 8182 8189 +7
+ Partials 1462 1457 -5 |
| return false | ||
| } | ||
| cond, _ := sortedValues[i].OrderBy[orderBy].Value.LT(sortedValues[j].OrderBy[orderBy].Value) | ||
| sort.Slice(sortedValues, func(i, j int) bool { |
There was a problem hiding this comment.
We should share this implementation with function_aggregate.go
There was a problem hiding this comment.
sort.SliceStable not available here ? ( https://pkg.go.dev/sort#SliceStable )
There was a problem hiding this comment.
We could use a stable sort, I don't think it'd make any difference.
The previous implementation was re-sorting the entire list for each ORDER BY expression that was provided. The new implementation maintains sort order within each group.
i.e. 2024-02-01 dt group in the test below has its rows sorted by letter when the dt fields are equal.
|
Thank you for your contribution !! LGTM 👍 |
Closes #140