Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes instructor & student list query and quiz link #336

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

brianhogg
Copy link
Contributor

Description

Removes the "quiz" link from lessons since the quiz resource doesn't exist.

Sets the default listing of the students and instructors endpoints to be role "student" and "instructor" by default. It can still be changed using the roles query param.

Refs #48
Fixes #330

How has this been tested?

Manually

Screenshots

Captura de pantalla 2024-07-17 a las 12 16 02 p  m Captura de pantalla 2024-07-17 a las 12 16 17 p  m

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@brianhogg brianhogg requested a review from ideadude as a code owner July 17, 2024 16:16
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scan Summary

Tool Critical High Medium Low Status
Dependency Scan (universal) 1 1 0 0
Secrets Audit 0 4 0 0
Shell Script Analysis 0 0 0 0

Recommendation

Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍

@brianhogg brianhogg merged commit 45750d9 into dev Jul 18, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant