Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifterlms.js uses unload event, which is scheduled to be removed from chrome. #2620

Closed
3 of 4 tasks
dominiquemariano opened this issue Mar 28, 2024 · 2 comments
Closed
3 of 4 tasks

Comments

@dominiquemariano
Copy link

Reproduction Steps

  1. Create a new site with a fresh install of LifterLMS.
  2. Analyze that site using pagespeed.web.dev
  3. In the results page, navigate down to General > Uses deprecated APIs

Expected Behavior

Shouldn't be using deprecated APIs that are scheduled to be removed from Chrome.

Actual Behavior

1 deprecation warning for UnloadHandler, as you can see in this screenshot. See https://developer.mozilla.org/en-US/docs/Web/API/Window/unload_event

This issue has be recreated:

  • Locally
  • On a staging site
  • On a production website
  • With only LifterLMS and a default theme
@brianhogg
Copy link
Contributor

Looks like this might be removed from Chrome by the end of Q1 2025. May need to prioritize this a little higher.

@brianhogg
Copy link
Contributor

https://developer.chrome.com/docs/web-platform/deprecating-unload

This appears to be related to the opt-in tracking script.

@brianhogg brianhogg moved this from Awaiting Triage to Awaiting Review in Development Nov 21, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Development Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants