Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unload event used in core Javascript #2812

Merged
merged 9 commits into from
Dec 17, 2024
Merged

Fix unload event used in core Javascript #2812

merged 9 commits into from
Dec 17, 2024

Conversation

brianhogg
Copy link
Contributor

@brianhogg brianhogg commented Nov 21, 2024 •
edited
Loading

Description

Changes the unload event to pagehide

Fixes #2620

How has this been tested?

Manually

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@brianhogg brianhogg requested a review from ideadude as a code owner November 21, 2024 15:37
@brianhogg
Copy link
Contributor Author

Want to test this pre and post implementing (with tracking enabled I think?) to make sure the pagespeed error goes away.

@brianhogg
Copy link
Contributor Author

Tested and error is gone from pagespeed.

@brianhogg brianhogg merged commit 21f0ce2 into dev Dec 17, 2024
24 checks passed
@brianhogg brianhogg deleted the fix/unload-event-in-tracking branch December 17, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ideadude ideadude Awaiting requested review from ideadude ideadude is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brianhogg