Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing number of lessons in Course Catalog and My Courses. #2439

Merged
merged 9 commits into from
Oct 26, 2023

Conversation

actuallyakash
Copy link
Contributor

Description

Showing the number of lessons paragraph in Course Catalog and My Courses.

Fixes #2434

How has this been tested?

Manually.

Screenshots

image

Types of changes

New feature

Checklist:

  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

in Course Catalog and My Courses.
@actuallyakash actuallyakash requested a review from a team May 18, 2023 12:05
@actuallyakash actuallyakash self-assigned this May 18, 2023
templates/course/length.php Show resolved Hide resolved
templates/course/lesson-count.php Outdated Show resolved Hide resolved
templates/course/lesson-count.php Outdated Show resolved Hide resolved
templates/course/lesson-count.php Outdated Show resolved Hide resolved
templates/course/lesson-count.php Show resolved Hide resolved
@gocodebox gocodebox deleted a comment from actuallyakash May 31, 2023
@eri-trabiccolo
Copy link
Collaborator

We need to decide some default behavior prior to merge more on this, because we're adding a new information all of a sudden. I think we can and people who don't want it can opt out.

@actuallyakash
Copy link
Contributor Author

We need to decide some default behavior prior to merge more on this, because we're adding a new information all of a sudden. I think we can and people who don't want it can opt out.

yeah, that sounds good. Like a checkbox to opt-out in LifterLMS Labs?

@eri-trabiccolo
Copy link
Collaborator

We need to decide some default behavior prior to merge more on this, because we're adding a new information all of a sudden. I think we can and people who don't want it can opt out.

yeah, that sounds good. Like a checkbox to opt-out in LifterLMS Labs?

Yeah but don't do that for now, I'll ping you :P

@eri-trabiccolo eri-trabiccolo merged commit 4a114e7 into gocodebox:dev Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants