Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the Course Builder new lesson View link #2663

Merged
merged 6 commits into from
May 28, 2024

Conversation

brianhogg
Copy link
Contributor

@brianhogg brianhogg commented May 16, 2024

Description

Dynamically generate the View link on a lesson if there isn't one passed via the back end. Also looks at the status of the lesson and generates a valid preview link if the status is set to Draft (Published unchecked) before a page refresh.

Fixes #2662

How has this been tested?

Manually

Screenshots

Fix.for.Lesson.View.Link.mov

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

brianhogg added 2 commits May 16, 2024 10:34
…_link() to generate a preview or permalink if one is not found in the model.
@brianhogg brianhogg added this to the Next Available Release milestone May 16, 2024
@brianhogg brianhogg requested a review from ideadude as a code owner May 16, 2024 14:52
@ideadude ideadude merged commit 8e87c5b into dev May 28, 2024
5 checks passed
@ideadude ideadude deleted the fix/course-builder-new-lesson-view-link branch May 28, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants