Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load setup wizard on init to avoid translation errors #2836

Merged
merged 9 commits into from
Dec 17, 2024
Merged

Load setup wizard on init to avoid translation errors #2836

merged 9 commits into from
Dec 17, 2024

Conversation

brianhogg
Copy link
Contributor

Description

Fixes #2835

How has this been tested?

Manually

Screenshots

CleanShot 2024-12-16 at 2  12 46@2x

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@brianhogg brianhogg requested a review from ideadude as a code owner December 16, 2024 19:14
@brianhogg brianhogg added this to the Next Available Release milestone Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 77.18% 328/425
🟡 Branches 68.45% 141/206
🟢 Functions 82.93% 68/82
🟡 Lines 76.68% 319/416

Test suite run success

169 tests passing in 22 suites.

Report generated by 🧪jest coverage report action from 99359b3

@brianhogg brianhogg merged commit b612d64 into dev Dec 17, 2024
24 checks passed
@brianhogg brianhogg deleted the fix/setup-wizard-translations branch December 17, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ideadude ideadude Awaiting requested review from ideadude ideadude is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Development
Status: Done
Milestone
Next Available Release
Development

Successfully merging this pull request may close these issues.
1 participant
@brianhogg