Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 7.8.7 #2838

Merged
merged 5 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
LifterLMS Changelog
===================

v7.8.7 - 2024-12-17
-------------------

##### Bug Fixes

+ Fix translation error during the setup wizard. [#2835](https://github.com/gocodebox/lifterlms/issues/2835)
+ Fixes Pagespeed notice regarding deprecated Javascript event usage. [#2620](https://github.com/gocodebox/lifterlms/issues/2620)


v7.8.6 - 2024-12-16
-------------------

Expand Down
2 changes: 1 addition & 1 deletion assets/js/app/llms-tracking.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ LLMS.Tracking = function( settings ) {
self.addEvent( 'page.load' );

window.addEventListener( 'beforeunload', onBeforeUnload );
window.addEventListener( 'unload', onUnload );
window.addEventListener( 'pagehide', onUnload );

document.addEventListener( 'visibilitychange', onVisibilityChange );

Expand Down
2 changes: 1 addition & 1 deletion class-lifterlms.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ final class LifterLMS {
*
* @var string
*/
public $version = '7.8.6';
public $version = '7.8.7';

/**
* LLMS_Assets instance
Expand Down
12 changes: 4 additions & 8 deletions includes/admin/class.llms.admin.setup.wizard.php
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ public function output_before_importable_course( array $course ): void {
</label>
</div>
<?php

}

/**
Expand Down Expand Up @@ -155,7 +154,6 @@ protected function get_completed_url( array $course_ids ): string {
}

return admin_url( 'edit.php?post_type=course&orderby=date&order=desc' );

}

/**
Expand All @@ -181,7 +179,6 @@ protected function save_coupon() {
}

return $ret;

}

/**
Expand All @@ -194,7 +191,6 @@ protected function save_coupon() {
protected function save_pages() {

return LLMS_Install::create_pages() ? true : new WP_Error( 'llms-setup-pages-save', esc_html__( 'There was an error saving your data, please try again.', 'lifterlms' ) );

}

/**
Expand All @@ -219,7 +215,6 @@ protected function save_payments(): bool {
// phpcs:enable WordPress.Security.NonceVerification.Missing

return true;

}

/**
Expand Down Expand Up @@ -251,9 +246,10 @@ protected function save_finish() {
}

return $gen->get_generated_courses();

}

}

return new LLMS_Admin_Setup_Wizard();
function llms_load_admin_setup_wizard() {
return new LLMS_Admin_Setup_Wizard();
}
add_action( 'init', 'llms_load_admin_setup_wizard' );
2 changes: 1 addition & 1 deletion lifterlms.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Plugin Name: LifterLMS
* Plugin URI: https://lifterlms.com/
* Description: Complete e-learning platform to sell online courses, protect lessons, offer memberships, and quiz students. WP Learning Management System.
* Version: 7.8.6
* Version: 7.8.7
* Author: LifterLMS
* Author URI: https://lifterlms.com/
* Text Domain: lifterlms
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "lifterlms",
"version": "7.8.6",
"version": "7.8.7",
"description": "LifterLMS by codeBOX",
"repository": {
"type": "git",
Expand Down
1 change: 1 addition & 0 deletions packages/llms-e2e-test-utils/src/import-course.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export async function importCourse(
await clickButton( 'Import' );

if ( navigate ) {
await page.waitForSelector( '.llms-admin-notice.notice-success a' );
await clickAndWait( '.llms-admin-notice.notice-success a' );
}
}
Loading