Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more html in quiz question descriptions #2842

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

brianhogg
Copy link
Contributor

Description

Things like the [audio] embed shortcode do not work when added to a quiz question because certain tags were removed via wp_kses_post. Also, the allowed HTML form fields array was missing some basic tags from the wp_kses_post listing.

This PR:

  1. Switches the quiz questions description template to use the tags defined in LLMS_ALLOWED_HTML_FORM_FIELDS
  2. Adds source as an allowed tag (part of the audio embed shortcode)
  3. Starts with the tags included via wp_kses_post and adds the ones that aren't already there

How has this been tested?

Manually

Screenshots

CleanShot 2025-01-03 at 3  20 25@2x

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

… form fields, and use this broader list for the quiz question description.
@brianhogg brianhogg requested a review from ideadude as a code owner January 3, 2025 20:20
@brianhogg brianhogg added this to the Next Available Release milestone Jan 3, 2025
@ideadude ideadude self-assigned this Jan 9, 2025
@brianhogg brianhogg merged commit 222cfe6 into dev Jan 13, 2025
24 checks passed
@brianhogg brianhogg deleted the allow-more-html-in-quiz-question branch January 13, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants