Fix fatal error that occurred when viewing quiz attempts with deleted questions. #2867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Viewing quiz attempts when questions were deleted would throw a fatal error:
How has this been tested?
To recreate the issue:
Types of changes
This issue was introduced by accident in the work to add the quiz resume feature. Some code was incorrectly updated to get data from the $question variable instead of the $attempt_question variable.
Note: Since
$attempt_question->get('question_type')
is always null, we instead addtype--deleted
as a css class on the li element instead of trying to find the type.Checklist: