Read gzipped response and request marshal include headers #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mumugoah
commented
Jun 21, 2018
•
mumugoah
commented
- add feather: read gzipped HTTP response
- fix: request marshal and unMarshal include headers (fix should request marshal include headers? #169 )
mumugoah
changed the title
asciimoo
requested changes
Jun 25, 2018
request.go
Outdated
| @@ -56,6 +56,7 @@ type serializableRequest struct { | |||
| Body []byte | |||
| ID uint32 | |||
| Ctx map[string]interface{} | |||
| Header http.Header | |||
There was a problem hiding this comment.
Please call it Headers to be compatible with the current naming convention.
http_backend.go
Outdated
| @@ -185,6 +187,12 @@ func (h *httpBackend) Do(request *http.Request, bodySize int) (*Response, error) | |||
| if bodySize > 0 { | |||
| bodyReader = io.LimitReader(bodyReader, int64(bodySize)) | |||
| } | |||
| if res.Header.Get("Content-Encoding") == "gzip" { | |||
There was a problem hiding this comment.
As I know golang's http lib handles compression by default. If it successfully decompresses the content, then res.Uncompressed [1] is true, so we could check here if decompression happened to avoid double decompression:
if !res.Uncompressed && res.Header.Get("Content-Encoding") == "gzip" {
|
@asciimoo ok, I'll correct it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.