Skip to content

Commit

Permalink
Integrate reviewdog
Browse files Browse the repository at this point in the history
  • Loading branch information
lbbniu committed Apr 24, 2022
1 parent 943b621 commit f52d504
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 36 deletions.
27 changes: 13 additions & 14 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -168,22 +168,21 @@ jobs:
- name: Build Metric Adapter
run: make metric-adapter

golangci:
name: lint
reviewdog:
name: reviewdog
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Setup Go environment
uses: actions/setup-go@v3.0.0
with:
# The Go version to download (if necessary) and use. Supports semver spec and ranges.
go-version: 1.17 # optional

- name: golangci-lint
uses: golangci/golangci-lint-action@v2
with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: v1.45.2

# Optional: golangci-lint command line arguments.
args: --timeout 30m --disable-all -E deadcode -E unused -E varcheck -E ineffassign -E goimports -E gofmt -E misspell -E unparam -E unconvert -E govet -E errcheck -E structcheck
uses: reviewdog/action-golangci-lint@v2
with:
go_version: "1.17"
github_token: ${{ secrets.GITHUB_TOKEN }}
# Change reviewdog reporter if you need [github-pr-check,github-check,github-pr-review].
reporter: github-pr-review
# Report all results.
filter_mode: nofilter
# Exit with 1 when it find at least one finding.
fail_on_error: true
golangci_lint_version: v1.45.2
22 changes: 0 additions & 22 deletions .github/workflows/reviewdog.yml

This file was deleted.

Binary file added bin/crane-agent
Binary file not shown.

0 comments on commit f52d504

Please sign in to comment.