Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance error handling for NotFound error in controller reconcile. #183

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Enhance error handling for NotFound error in controller reconcile. #183

merged 1 commit into from
Mar 7, 2022

Conversation

wenhug
Copy link
Contributor

@wenhug wenhug commented Mar 4, 2022

fixes #182

Copy link
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Please rebase newest code and recommit.

pkg/controller/noderesource/node_resource_controller.go Outdated Show resolved Hide resolved
@qmhu
Copy link
Member

qmhu commented Mar 7, 2022

/LGTM

@qmhu qmhu changed the title controller reconcile ignore not found error Enhance error handling for NotFound error in controller reconcile. Mar 7, 2022
@qmhu qmhu merged commit dc19b13 into gocrane:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller reconcile should ignore not found error
2 participants