Sort pods to be executed in multi dimensions #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenkaiyue
changed the title
chenkaiyue
force-pushed
the
sort-port
branch
4 times, most recently
from
6dfd3dd
to
d42e963
Compare
|
As discussed with @mfanjie, we do not need to make custom rank options now, and just make users easy to use, so i delete custom options related codes. |
2 tasks
chenkaiyue
changed the title
|
🎉 Successfully Build Images. Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages
|
mfanjie
reviewed
May 9, 2022
| // combine the replicated pod | ||
| combineEvictDuplicate(&ae.EvictExecutor, evictPods) | ||
| } | ||
| } | ||
|
|
||
| // sort the throttle executor by pod qos priority | ||
| sort.Sort(ae.ThrottleExecutor.ThrottleDownPods) | ||
| sort.Sort(sort.Reverse(ae.ThrottleExecutor.ThrottleUpPods)) | ||
| execsort.CpuMetricsSorter(ae.ThrottleExecutor.ThrottleDownPods) |
There was a problem hiding this comment.
why it's cpu sorter? if there is other metrics, do you need sort again? should you have a more generic function for sorting?
| package sort | ||
|
|
||
| import ( | ||
| "k8s.io/klog/v2" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What this PR does / why we need it: