refine querybuilder factory to register way, to avoid switch case mod… #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. each implementer only register by init way
|
/LGTM |
qmhu
reviewed
Apr 14, 2022
|
|
||
| type BuilderFactoryFunc func(metric *metricquery.Metric) Builder | ||
|
|
||
| func RegisterBuilderFactory(metricSource metricquery.MetricSource, initFunc BuilderFactoryFunc) { |
|
😭 Deploy PR Preview eaf446f failed. Build logs
🤖 By surge-preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e. each implementer only register by init way
What type of PR is this?
refine querybuilder factory to register way
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #238
Special notes for your reviewer: