feat(pkg/web): Add a test for the crane url to avoid Grafana 404. #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmhu
reviewed
Apr 24, 2022
| @@ -80,6 +80,9 @@ export const EditClusterModal = React.memo(() => { | |||
| } else if (!cluster.craneUrl.startsWith('http://') && !cluster.craneUrl.startsWith('https://')) { | |||
| res.error = true; | |||
| res.msg = t('Crane URL格式不正确，请输入正确的URL'); | |||
There was a problem hiding this comment.
Maybe we can also add a sample url in placeholder .
zsnmwy
force-pushed
the
add_crane_url_tips
branch
2 times, most recently
from
2085aed
to
4f90410
Compare
|
🎉 Successfully Build Images. Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages
|
|
|
Signed-off-by: zsnmwy <szlszl35622@gmail.com>
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a test for the crane url to avoid Grafana 404.
Which issue(s) this PR fixes: