Add metric ext_cpu_total_distribute for local state #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Successfully Build Images. Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages
|
shijieqin
force-pushed
the
add_ext_cpu_total_distribute_metrics_for_local_state
branch
from
f651770
to
6fb275b
Compare
|
Can you give an example for how to use the "ext_cpu_total_distribute" metric? @shijieqin |
| @@ -179,6 +180,13 @@ func (s *StateCollector) UpdateCollectors() { | |||
| if _, exists := s.collectors.Load(types.CadvisorCollectorType); !exists { | |||
| s.collectors.Store(types.CadvisorCollectorType, cadvisor.NewCadvisorCollector(s.podLister, s.GetCadvisorManager())) | |||
There was a problem hiding this comment.
If the node resource feature disabled, we can not collect the metric, can we add a judge for it
shijieqin
force-pushed
the
add_ext_cpu_total_distribute_metrics_for_local_state
branch
from
6fb275b
to
a19070e
Compare
I added a NodeQOSEnsurancePolicy called disablescheduling-when-ext-cpu-total-distribute |
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add metric ext_cpu_total_distribute for local state