Watch configSet file and update config for recommendation on the fly. #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Prometheus use a sidecar to reload configmap change, can we use it? |
|
🎉 Successfully Build Images. Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages
|
|
@yufeiyu we need to upgrade recommendation-config to the crane-config which include multiple type configs for different functions, like prometheus-config, if so, the configmap-loader seems more suitable for us. |
yufeiyu
force-pushed
the
feat/watch_recommendationConfigFile
branch
from
ebeb4c7
to
4022f5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
What this PR does / why we need it:
Watch configSet file and update config for recommendation on the fly.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: