Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make crane's namespace configurable #384

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Make crane's namespace configurable #384

merged 1 commit into from
Jun 30, 2022

Conversation

lbbniu
Copy link
Member

@lbbniu lbbniu commented Jun 29, 2022

What type of PR is this?

Make crane's namespace configurable

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #381

Special notes for your reviewer:

@github-actions
Copy link
Contributor

🎉 Successfully Build Images.

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-384-a8f0fdd docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-384-a8f0fdd
dashboard:pr-384-a8f0fdd docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-384-a8f0fdd
metric-adapter:pr-384-a8f0fdd docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-384-a8f0fdd
craned:pr-384-a8f0fdd docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-384-a8f0fdd

@qmhu
Copy link
Member

qmhu commented Jun 30, 2022

/LGTM

@qmhu qmhu merged commit fb918ce into gocrane:main Jun 30, 2022
@lbbniu lbbniu deleted the feature/lbbniu/namespace branch May 16, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make crane's namespace configurable
2 participants
@lbbniu @qmhu