Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify external metrics and add metrics with windows #461

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Modify external metrics and add metrics with windows #461

merged 1 commit into from
Aug 8, 2022

Conversation

saikey0379
Copy link
Contributor

Modify external metrics and add metrics by windows

What type of PR is this?
Metrics

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

🎉 Successfully Build Images.

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-461-3268e47 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-461-3268e47
dashboard:pr-461-3268e47 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-461-3268e47
metric-adapter:pr-461-3268e47 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-461-3268e47
craned:pr-461-3268e47 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-461-3268e47

qmhu
qmhu approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@qmhu qmhu merged commit 276ef7e into gocrane:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmhu qmhu qmhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saikey0379 @qmhu