Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: pkg-utils-slice #473

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Test: pkg-utils-slice #473

merged 1 commit into from
Aug 15, 2022

Conversation

jxs1211
Copy link
Contributor

@jxs1211 jxs1211 commented Aug 13, 2022

What type of PR is this?

This is an unit test for pkg-utils-slice

What this PR does / why we need it:

This is a unit test for pkg-utils-slice

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

[going@dev utils]$ go test -cover -v slice_test.go slice.go
=== RUN TestContainsString
=== RUN TestContainsString/slice_is_empty
=== RUN TestContainsString/searching_object_exists_the_slice
=== RUN TestContainsString/searching_object_doesn't_exist_the_slice
--- PASS: TestContainsString (0.00s)
--- PASS: TestContainsString/slice_is_empty (0.00s)
--- PASS: TestContainsString/searching_object_exists_the_slice (0.00s)
--- PASS: TestContainsString/searching_object_doesn't_exist_the_slice (0.00s)
=== RUN TestRemoveString
=== RUN TestRemoveString/removing_object_exists_the_slice
=== RUN TestRemoveString/remove_object_doesn't_exist_in_the_slice
=== RUN TestRemoveString/the_slice_is_empty
--- PASS: TestRemoveString (0.00s)
--- PASS: TestRemoveString/removing_object_exists_the_slice (0.00s)
--- PASS: TestRemoveString/remove_object_doesn't_exist_in_the_slice (0.00s)
--- PASS: TestRemoveString/the_slice_is_empty (0.00s)
PASS
coverage: 100.0% of statements

Signed-off-by: xian-jie.shen <327411586@qq.com>
@github-actions
Copy link
Contributor

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2022-08-13 15:19
Git Version: 36c23ef

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-473-36c23ef docker pull gocrane/crane-agent:pr-473-36c23ef
dashboard:pr-473-36c23ef docker pull gocrane/dashboard:pr-473-36c23ef
metric-adapter:pr-473-36c23ef docker pull gocrane/metric-adapter:pr-473-36c23ef
craned:pr-473-36c23ef docker pull gocrane/craned:pr-473-36c23ef

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-473-36c23ef \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-473-36c23ef \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-473-36c23ef \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-473-36c23ef crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-473-36c23ef docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-473-36c23ef
dashboard:pr-473-36c23ef docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-473-36c23ef
metric-adapter:pr-473-36c23ef docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-473-36c23ef
craned:pr-473-36c23ef docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-473-36c23ef

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-473-36c23ef \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-473-36c23ef \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-473-36c23ef \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-473-36c23ef crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-473-36c23ef docker pull ghcr.io/gocrane/crane/crane-agent:pr-473-36c23ef
dashboard:pr-473-36c23ef docker pull ghcr.io/gocrane/crane/dashboard:pr-473-36c23ef
metric-adapter:pr-473-36c23ef docker pull ghcr.io/gocrane/crane/metric-adapter:pr-473-36c23ef
craned:pr-473-36c23ef docker pull ghcr.io/gocrane/crane/craned:pr-473-36c23ef

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-473-36c23ef \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-473-36c23ef \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-473-36c23ef \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-473-36c23ef crane/crane

@qmhu
Copy link
Member

qmhu commented Aug 14, 2022

Please fix go lint

@jxs1211
Copy link
Contributor Author

jxs1211 commented Aug 15, 2022

Please fix go lint

I try to reproduce the issue on my local environment, but it seems ok.

[going@dev crane]$ gs
On branch test-pkg-utils-slice
[going@dev crane]$ make lint
[going@dev crane]$ 

@zsnmwy
Copy link
Member

zsnmwy commented Aug 15, 2022

There is no question about this pull request.
The ci task has some problems.

#477

@qmhu qmhu merged commit 89aae6d into gocrane:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants