-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: pkg-utils-slice #473
Conversation
Signed-off-by: xian-jie.shen <327411586@qq.com>
🎉 Successfully Build Images. Docker RegistryOverview: https://hub.docker.com/u/gocrane
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=gocrane/craned \
--set craned.image.tag=pr-473-36c23ef \
--set metricAdapter.image.repository=gocrane/metric-adapter \
--set metricAdapter.image.tag=pr-473-36c23ef \
--set craneAgent.image.repository=gocrane/crane-agent \
--set craneAgent.image.tag=pr-473-36c23ef \
--set cranedDashboard.image.repository=gocrane/dashboard \
--set cranedDashboard.image.tag=pr-473-36c23ef crane/crane Coding RegistryOverview: https://finops.coding.net/public-artifacts/gocrane/crane/packages
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
--set craned.image.tag=pr-473-36c23ef \
--set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-473-36c23ef \
--set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-473-36c23ef \
--set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-473-36c23ef crane/crane Ghcr RegistryOverview: https://github.com/orgs/gocrane/packages?repo_name=crane
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=ghcr.io/gocrane/crane/craned \
--set craned.image.tag=pr-473-36c23ef \
--set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-473-36c23ef \
--set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-473-36c23ef \
--set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-473-36c23ef crane/crane |
Please fix go lint |
I try to reproduce the issue on my local environment, but it seems ok.
|
There is no question about this pull request. |
What type of PR is this?
This is an unit test for pkg-utils-slice
What this PR does / why we need it:
This is a unit test for pkg-utils-slice
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
[going@dev utils]$ go test -cover -v slice_test.go slice.go
=== RUN TestContainsString
=== RUN TestContainsString/slice_is_empty
=== RUN TestContainsString/searching_object_exists_the_slice
=== RUN TestContainsString/searching_object_doesn't_exist_the_slice
--- PASS: TestContainsString (0.00s)
--- PASS: TestContainsString/slice_is_empty (0.00s)
--- PASS: TestContainsString/searching_object_exists_the_slice (0.00s)
--- PASS: TestContainsString/searching_object_doesn't_exist_the_slice (0.00s)
=== RUN TestRemoveString
=== RUN TestRemoveString/removing_object_exists_the_slice
=== RUN TestRemoveString/remove_object_doesn't_exist_in_the_slice
=== RUN TestRemoveString/the_slice_is_empty
--- PASS: TestRemoveString (0.00s)
--- PASS: TestRemoveString/removing_object_exists_the_slice (0.00s)
--- PASS: TestRemoveString/remove_object_doesn't_exist_in_the_slice (0.00s)
--- PASS: TestRemoveString/the_slice_is_empty (0.00s)
PASS
coverage: 100.0% of statements