Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine cpu sorter of crane agent #487

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

mfanjie
Copy link
Contributor

@mfanjie mfanjie commented Aug 18, 2022

What type of PR is this?

refine some crane agent code, like remove ClassAndPriority struct and reorg sorters.

What this PR does / why we need it:

Which issue(s) this PR fixes:

  • remove intermediate PriorityAndQOSClass
  • simplify some implmentation like toggle node scheduling and throttling
  • refine sort functions

Special notes for your reviewer:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2022

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2022-08-19 14:55
Git Version: 01ea2e7

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-487-01ea2e7 docker pull gocrane/crane-agent:pr-487-01ea2e7
dashboard:pr-487-01ea2e7 docker pull gocrane/dashboard:pr-487-01ea2e7
metric-adapter:pr-487-01ea2e7 docker pull gocrane/metric-adapter:pr-487-01ea2e7
craned:pr-487-01ea2e7 docker pull gocrane/craned:pr-487-01ea2e7

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-487-01ea2e7 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-487-01ea2e7 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-487-01ea2e7 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-487-01ea2e7 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-487-01ea2e7 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-487-01ea2e7
dashboard:pr-487-01ea2e7 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-487-01ea2e7
metric-adapter:pr-487-01ea2e7 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-487-01ea2e7
craned:pr-487-01ea2e7 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-487-01ea2e7

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-487-01ea2e7 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-487-01ea2e7 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-487-01ea2e7 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-487-01ea2e7 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-487-01ea2e7 docker pull ghcr.io/gocrane/crane/crane-agent:pr-487-01ea2e7
dashboard:pr-487-01ea2e7 docker pull ghcr.io/gocrane/crane/dashboard:pr-487-01ea2e7
metric-adapter:pr-487-01ea2e7 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-487-01ea2e7
craned:pr-487-01ea2e7 docker pull ghcr.io/gocrane/crane/craned:pr-487-01ea2e7

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-487-01ea2e7 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-487-01ea2e7 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-487-01ea2e7 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-487-01ea2e7 crane/crane

@mfanjie mfanjie force-pushed the actionablepods branch 4 times, most recently from 4aa815e to 8eeafc7 Compare August 18, 2022 11:45
Copy link
Contributor

@chenkaiyue chenkaiyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chenkaiyue chenkaiyue merged commit 3c9a289 into gocrane:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants