Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NRT collector #544

Merged
merged 2 commits into from
Sep 19, 2022
Merged

add NRT collector #544

merged 2 commits into from
Sep 19, 2022

Conversation

Garrybest
Copy link
Member

Signed-off-by: Garrybest garrybest@foxmail.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2022-09-19 15:16
Git Version: f863c4f

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-544-f863c4f docker pull gocrane/crane-agent:pr-544-f863c4f
dashboard:pr-544-f863c4f docker pull gocrane/dashboard:pr-544-f863c4f
metric-adapter:pr-544-f863c4f docker pull gocrane/metric-adapter:pr-544-f863c4f
craned:pr-544-f863c4f docker pull gocrane/craned:pr-544-f863c4f

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-544-f863c4f \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-544-f863c4f \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-544-f863c4f \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-544-f863c4f crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-544-f863c4f docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-544-f863c4f
dashboard:pr-544-f863c4f docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-544-f863c4f
metric-adapter:pr-544-f863c4f docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-544-f863c4f
craned:pr-544-f863c4f docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-544-f863c4f

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-544-f863c4f \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-544-f863c4f \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-544-f863c4f \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-544-f863c4f crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-544-f863c4f docker pull ghcr.io/gocrane/crane/crane-agent:pr-544-f863c4f
dashboard:pr-544-f863c4f docker pull ghcr.io/gocrane/crane/dashboard:pr-544-f863c4f
metric-adapter:pr-544-f863c4f docker pull ghcr.io/gocrane/crane/metric-adapter:pr-544-f863c4f
craned:pr-544-f863c4f docker pull ghcr.io/gocrane/crane/craned:pr-544-f863c4f

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-544-f863c4f \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-544-f863c4f \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-544-f863c4f \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-544-f863c4f crane/crane

@chenkaiyue
Copy link
Contributor

chenkaiyue commented Sep 5, 2022

CI waterline approved

Signed-off-by: Garrybest <garrybest@foxmail.com>
@Garrybest Garrybest changed the title collect NRT when crane-agent starts add NRT collector Sep 17, 2022
pkg/features/features.go Outdated Show resolved Hide resolved
pkg/ensurance/collector/collector.go Outdated Show resolved Hide resolved
Signed-off-by: Garrybest <garrybest@foxmail.com>
Copy link
Contributor

@mfanjie mfanjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfanjie mfanjie merged commit 8f5e946 into gocrane:main Sep 19, 2022
@Garrybest Garrybest deleted the pr_nrt branch September 19, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants