Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change event type when meet error #656

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Conversation

whitebear009
Copy link
Contributor

What type of PR is this?

optimization

What this PR does / why we need it:

change event type when meet error

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions github-actions bot added area:algorithm crane algorithm area:autoscaling documentation Improvements or additions to documentation labels Dec 16, 2022
@github-actions
Copy link
Contributor

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2022-12-16 15:37
Git Version: 3d78d10

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-656-3d78d10 docker pull gocrane/crane-agent:pr-656-3d78d10
dashboard:pr-656-3d78d10 docker pull gocrane/dashboard:pr-656-3d78d10
metric-adapter:pr-656-3d78d10 docker pull gocrane/metric-adapter:pr-656-3d78d10
craned:pr-656-3d78d10 docker pull gocrane/craned:pr-656-3d78d10

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-656-3d78d10 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-656-3d78d10 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-656-3d78d10 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-656-3d78d10 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-656-3d78d10 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-656-3d78d10
dashboard:pr-656-3d78d10 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-656-3d78d10
metric-adapter:pr-656-3d78d10 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-656-3d78d10
craned:pr-656-3d78d10 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-656-3d78d10

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-656-3d78d10 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-656-3d78d10 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-656-3d78d10 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-656-3d78d10 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-656-3d78d10 docker pull ghcr.io/gocrane/crane/crane-agent:pr-656-3d78d10
dashboard:pr-656-3d78d10 docker pull ghcr.io/gocrane/crane/dashboard:pr-656-3d78d10
metric-adapter:pr-656-3d78d10 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-656-3d78d10
craned:pr-656-3d78d10 docker pull ghcr.io/gocrane/crane/craned:pr-656-3d78d10

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-656-3d78d10 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-656-3d78d10 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-656-3d78d10 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-656-3d78d10 crane/crane

@whitebear009
Copy link
Contributor Author

/assign @qmhu PTAL, thanks

Copy link
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@qmhu qmhu merged commit ea3976c into gocrane:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:algorithm crane algorithm area:autoscaling documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants