Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove owner_replicas in metric #697

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Conversation

qmhu
Copy link
Member

@qmhu qmhu commented Feb 20, 2023

What type of PR is this?

bugfix

What this PR does / why we need it:

owner_replicas is a args which will lead to metric bigger.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@qmhu qmhu added the kind/bug Something isn't working label Feb 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2023

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2023-02-20 20:38
Git Version: 2ffdb79

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-697-2ffdb79 docker pull gocrane/crane-agent:pr-697-2ffdb79
dashboard:pr-697-2ffdb79 docker pull gocrane/dashboard:pr-697-2ffdb79
metric-adapter:pr-697-2ffdb79 docker pull gocrane/metric-adapter:pr-697-2ffdb79
craned:pr-697-2ffdb79 docker pull gocrane/craned:pr-697-2ffdb79

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-697-2ffdb79 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-697-2ffdb79 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-697-2ffdb79 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-697-2ffdb79 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-697-2ffdb79 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-697-2ffdb79
dashboard:pr-697-2ffdb79 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-697-2ffdb79
metric-adapter:pr-697-2ffdb79 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-697-2ffdb79
craned:pr-697-2ffdb79 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-697-2ffdb79

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-697-2ffdb79 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-697-2ffdb79 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-697-2ffdb79 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-697-2ffdb79 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-697-2ffdb79 docker pull ghcr.io/gocrane/crane/crane-agent:pr-697-2ffdb79
dashboard:pr-697-2ffdb79 docker pull ghcr.io/gocrane/crane/dashboard:pr-697-2ffdb79
metric-adapter:pr-697-2ffdb79 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-697-2ffdb79
craned:pr-697-2ffdb79 docker pull ghcr.io/gocrane/crane/craned:pr-697-2ffdb79

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-697-2ffdb79 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-697-2ffdb79 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-697-2ffdb79 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-697-2ffdb79 crane/crane

@qmhu qmhu merged commit c330f13 into gocrane:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:recommendation kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sum(crane_analysis_resource_recommendation{resource="cpu"}) 推荐总量会不断上涨, why?
1 participant