Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated configuration in example #730

Merged
merged 1 commit into from
Apr 20, 2023
Merged

remove deprecated configuration in example #730

merged 1 commit into from
Apr 20, 2023

Conversation

liu-song
Copy link
Contributor

What type of PR is this?

fix

What this PR does / why we need it:

analytics.analysis.crane.io is deprecated.

Which issue(s) this PR fixes:

Fixes #719

Special notes for your reviewer:

@github-actions
Copy link
Contributor

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2023-04-19 20:20
Git Version: 9b036ce

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-730-9b036ce docker pull gocrane/crane-agent:pr-730-9b036ce
dashboard:pr-730-9b036ce docker pull gocrane/dashboard:pr-730-9b036ce
metric-adapter:pr-730-9b036ce docker pull gocrane/metric-adapter:pr-730-9b036ce
craned:pr-730-9b036ce docker pull gocrane/craned:pr-730-9b036ce

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-730-9b036ce \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-730-9b036ce \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-730-9b036ce \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-730-9b036ce crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-730-9b036ce docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-730-9b036ce
dashboard:pr-730-9b036ce docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-730-9b036ce
metric-adapter:pr-730-9b036ce docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-730-9b036ce
craned:pr-730-9b036ce docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-730-9b036ce

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-730-9b036ce \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-730-9b036ce \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-730-9b036ce \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-730-9b036ce crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-730-9b036ce docker pull ghcr.io/gocrane/crane/crane-agent:pr-730-9b036ce
dashboard:pr-730-9b036ce docker pull ghcr.io/gocrane/crane/dashboard:pr-730-9b036ce
metric-adapter:pr-730-9b036ce docker pull ghcr.io/gocrane/crane/metric-adapter:pr-730-9b036ce
craned:pr-730-9b036ce docker pull ghcr.io/gocrane/crane/craned:pr-730-9b036ce

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-730-9b036ce \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-730-9b036ce \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-730-9b036ce \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-730-9b036ce crane/crane

Copy link
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qmhu qmhu merged commit de3aff3 into gocrane:main Apr 20, 2023
@liu-song liu-song deleted the crane branch April 20, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should Remove Deprecated Configuration In Example
2 participants