Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 优化前端代码 #749

Merged
merged 2 commits into from
May 4, 2023
Merged

feat: 优化前端代码 #749

merged 2 commits into from
May 4, 2023

Conversation

PmcFizz
Copy link
Contributor

@PmcFizz PmcFizz commented Apr 28, 2023

What type of PR is this?

优化前端代码,当前key,与value相同时,按照elsint的规则,应该只保留一个即可。

What this PR does / why we need it:

保持代码的简介和符合eslint格式校验。

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2023

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2023-04-28 12:42
Git Version: a0cd434

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-749-a0cd434 docker pull gocrane/crane-agent:pr-749-a0cd434
dashboard:pr-749-a0cd434 docker pull gocrane/dashboard:pr-749-a0cd434
metric-adapter:pr-749-a0cd434 docker pull gocrane/metric-adapter:pr-749-a0cd434
craned:pr-749-a0cd434 docker pull gocrane/craned:pr-749-a0cd434

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-749-a0cd434 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-749-a0cd434 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-749-a0cd434 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-749-a0cd434 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-749-a0cd434 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-749-a0cd434
dashboard:pr-749-a0cd434 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-749-a0cd434
metric-adapter:pr-749-a0cd434 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-749-a0cd434
craned:pr-749-a0cd434 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-749-a0cd434

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-749-a0cd434 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-749-a0cd434 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-749-a0cd434 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-749-a0cd434 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-749-a0cd434 docker pull ghcr.io/gocrane/crane/crane-agent:pr-749-a0cd434
dashboard:pr-749-a0cd434 docker pull ghcr.io/gocrane/crane/dashboard:pr-749-a0cd434
metric-adapter:pr-749-a0cd434 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-749-a0cd434
craned:pr-749-a0cd434 docker pull ghcr.io/gocrane/crane/craned:pr-749-a0cd434

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-749-a0cd434 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-749-a0cd434 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-749-a0cd434 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-749-a0cd434 crane/crane

@qmhu qmhu merged commit 6d9fcfd into gocrane:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants