Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider structured logging for aggregator, too. #462

Closed
s-l-teichmann opened this issue Sep 25, 2023 · 0 comments · Fixed by #530
Closed

Consider structured logging for aggregator, too. #462

s-l-teichmann opened this issue Sep 25, 2023 · 0 comments · Fixed by #530
Assignees
@tschmidtb51
Labels
csaf_aggregator enhancement New feature or request
Milestone
Next minor versio...

Comments

@s-l-teichmann
Copy link
Contributor

The downloader now sports structure logging as its focus shifted towards an automation tool.
The aggregator always was thought as such a tool.
Therefore the aggregator should use the structured logging, too.
@s-l-teichmann s-l-teichmann added enhancement New feature or request csaf_aggregator labels Sep 25, 2023
oxisto added a commit to oxisto/csaf_distribution that referenced this issue Apr 18, 2024
@oxisto
Added support for structured logging in csaf_aggretator
0e95ed4 
This PR adds structured logging for the aggregator service. Currently, only the text handler is used, but I can extend this to use the JSON handler as well. In this case, probably some code that is shared between the aggregator and the downloader would need to be moved to a common package.

I was also wondering, whether this repo is moving to Go 1.21 at the future, since `slog` was introduced in to the standard lib in 1.21. So currently, this still relies on the `x/exp` package.

Fixes gocsaf#462
@oxisto oxisto mentioned this issue Apr 18, 2024
Merged
oxisto added a commit to oxisto/csaf_distribution that referenced this issue Apr 18, 2024
@oxisto
Added support for structured logging in csaf_aggretator
e658738 
This PR adds structured logging for the aggregator service. Currently, only the text handler is used, but I can extend this to use the JSON handler as well. In this case, probably some code that is shared between the aggregator and the downloader would need to be moved to a common package.

I was also wondering, whether this repo is moving to Go 1.21 at the future, since `slog` was introduced in to the standard lib in 1.21. So currently, this still relies on the `x/exp` package.

Fixes gocsaf#462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tschmidtb51 tschmidtb51

Labels
csaf_aggregator enhancement New feature or request
Projects
None yet
Milestone
Next minor version 3.2.0
Development

Successfully merging a pull request may close this issue.

Added support for structured logging in csaf_aggregator oxisto/csaf_distribution
3 participants
@s-l-teichmann @bernhardreiter @tschmidtb51