Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uploader: use the TOML config file infrastructure, too. #439

Merged
merged 8 commits into from
Aug 22, 2023
Merged

uploader: use the TOML config file infrastructure, too. #439

merged 8 commits into from
Aug 22, 2023

Conversation

s-l-teichmann
Copy link
Contributor

part of #417

JanHoefelmeyer
JanHoefelmeyer previously approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works

@s-l-teichmann s-l-teichmann changed the title uploader: use the TOML config file intrastructure, too. uploader: use the TOML config file infrastructure, too. Aug 22, 2023
JanHoefelmeyer
JanHoefelmeyer approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works

ThomasJunk
ThomasJunk approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works

@s-l-teichmann s-l-teichmann merged commit f2657bb into main Aug 22, 2023
2 checks passed
@s-l-teichmann s-l-teichmann deleted the uploader-toml branch August 22, 2023 15:18
@JanHoefelmeyer JanHoefelmeyer mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanHoefelmeyer JanHoefelmeyer JanHoefelmeyer approved these changes

@ThomasJunk ThomasJunk ThomasJunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-l-teichmann @ThomasJunk @JanHoefelmeyer