-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build for macOS #476
Add build for macOS #476
Conversation
Hi @fjd-anh, thanks for creating a pull request for MacOS support. How many parts of the toolset did you test so far? |
So far the darwin builds will not be distributed as part of the release, is that on purpose? (I wonder does cross compilation work fine?) |
I was specially interested on a mac version of the downloader and only tried this one.
No. I missed this. If you want to provide the binaries, I'll add this to the Makefile. |
Yes, it would be nice to have this as binary so we get it into the release assets. Maybe just like the windows zip file, leaving out the csaf_provider and the csaf_aggregator. Would it be okay to do one archives for both sets of MacOS' binaries? We need to do a test on MacOS as well and we need to ask the BSI who is funding the development of these tools, before we can integrate it. This may take a few days. |
@bernhardreiter I changed the build targets and added them to the dist target. |
Our test on MacOS for the four client application will be done by @cintek |
We got the permission to activate a build and add client binaries to the release, noting that they are "community supported". |
Added a note for the readme and an archive to be added, if we do a release. So waiting for our test from @cintek now. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What I tested so far are downloader and validator and they are working as expected. Next step is to prepare the Mac to test provider and uploader. |
What I tested so far are downloader and validator and they are working as
expected. Next step is to prepare the Mac to test provider and uploader.
Would it be fine to test the validator and checker instead of the provider?
You can use a validation server and a provider on a GNU/Linux VM.
|
I tested the validator already. Now I also tested the checker by using verbose and version flag, writing the output to a file and using a config file. All of this just worked fine. |
@cintek cool! Did you also check the uploader? (To e.g. upload to a provider running on a GNU/Linux system)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (and @cintek tested that binaries work)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added Support for macOS.