Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build for macOS #476

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Add build for macOS #476

merged 4 commits into from
Nov 8, 2023

Conversation

fjd-anh
Copy link

@fjd-anh fjd-anh commented Oct 6, 2023

Added Support for macOS.

@bernhardreiter
Copy link
Member

bernhardreiter commented Oct 6, 2023

Hi @fjd-anh, thanks for creating a pull request for MacOS support.

How many parts of the toolset did you test so far?
(I wonder also if manually running the scripts for testing are successful.)

Makefile Outdated Show resolved Hide resolved
@bernhardreiter
Copy link
Member

So far the darwin builds will not be distributed as part of the release, is that on purpose? (I wonder does cross compilation work fine?)

@fjd-anh
Copy link
Author

fjd-anh commented Oct 6, 2023

Hi @fjd-anh, thanks for creating a pull request for MacOS support.

How many parts of the toolset did you test so far? (I wonder also if manually running the scripts for testing are successful.)

I was specially interested on a mac version of the downloader and only tried this one.
The downloader and the validator work fine.
From the other tools, I only checked the --help output.

So far the darwin builds will not be distributed as part of the release, is that on purpose? (I wonder does cross compilation work fine?)

No. I missed this. If you want to provide the binaries, I'll add this to the Makefile.

@bernhardreiter
Copy link
Member

Yes, it would be nice to have this as binary so we get it into the release assets. Maybe just like the windows zip file, leaving out the csaf_provider and the csaf_aggregator. Would it be okay to do one archives for both sets of MacOS' binaries?

We need to do a test on MacOS as well and we need to ask the BSI who is funding the development of these tools, before we can integrate it. This may take a few days.

@fjd-anh
Copy link
Author

fjd-anh commented Oct 6, 2023

@bernhardreiter I changed the build targets and added them to the dist target.

@bernhardreiter
Copy link
Member

Our test on MacOS for the four client application will be done by @cintek

@bernhardreiter
Copy link
Member

We got the permission to activate a build and add client binaries to the release, noting that they are "community supported".

@bernhardreiter bernhardreiter requested review from JanHoefelmeyer and removed request for tschmidtb51 October 13, 2023 15:54
@bernhardreiter
Copy link
Member

Added a note for the readme and an archive to be added, if we do a release. So waiting for our test from @cintek now. :)

JanHoefelmeyer
JanHoefelmeyer previously approved these changes Oct 16, 2023
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cintek
Copy link
Contributor

cintek commented Oct 18, 2023

What I tested so far are downloader and validator and they are working as expected. Next step is to prepare the Mac to test provider and uploader.

@bernhardreiter
Copy link
Member

bernhardreiter commented Oct 18, 2023 via email

@cintek
Copy link
Contributor

cintek commented Oct 30, 2023

What I tested so far are downloader and validator and they are working as expected. Next step is to prepare the Mac to test provider and uploader.
Would be find to test the validator and checker instead of the provider? You can use a validation server and a provider on a GNU/Linux VM.

I tested the validator already. Now I also tested the checker by using verbose and version flag, writing the output to a file and using a config file. All of this just worked fine.

@bernhardreiter
Copy link
Member

@cintek cool!

Did you also check the uploader? (To e.g. upload to a provider running on a GNU/Linux system)?

Copy link
Member

@bernhardreiter bernhardreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and @cintek tested that binaries work)

Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanHoefelmeyer JanHoefelmeyer merged commit 466d2c6 into gocsaf:main Nov 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants