Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mit to apache2.0 #535

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Mit to apache2.0 #535

merged 3 commits into from
Apr 24, 2024

Conversation

JanHoefelmeyer
Copy link
Contributor

Changes all original files currently licensed under MIT to Apache.
Contributes towards #532

@cintek
Copy link
Contributor

cintek commented Apr 22, 2024

I'm not sure if the MIT license is the correct one for the machine generated code (see this commit). Isn't the code generated from the schemas in csaf/schema/cvss-v2.0.json and csaf/schema/cvss-v3.0.json? As those have a "custom" license I would expect that we have to use that license. But I think @bernhardreiter can bring light into the dark.

If we use the MIT license for the machine generated code the files csaf/cvss20enums.go and csaf/cvss3enums.go also will have to be licensed under MIT.

@JanHoefelmeyer
Copy link
Contributor Author

JanHoefelmeyer commented Apr 23, 2024

How to license generated code was indeed also a question I had and an action I'd defer for now, see #534. The commit you linked is actually not a change, it's undoing the change of a prior commit.

Copy link
Member

@bernhardreiter bernhardreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cintek cintek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the license for the machine generated code the rest LGTM.

@cintek cintek merged commit 85b67f6 into main Apr 24, 2024
3 checks passed
@bernhardreiter bernhardreiter deleted the MIT-to-Apache2.0 branch April 25, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants