Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Compatibility Refactor #1261

Merged
merged 2 commits into from
Jan 22, 2020
Merged

E2E Compatibility Refactor #1261

merged 2 commits into from
Jan 22, 2020

Conversation

AnthonyLedesma
Copy link
Member

@AnthonyLedesma AnthonyLedesma commented Jan 15, 2020

Refactor tests and helpers to support the expected features of WP 5.4 (or Gutenberg 7.2) and is compatible with and without the Gutenberg plugin active.

ESLint

  • Applied ESLint to all tests and helper.js.
  • Installed Cypress ESLint plugin.
  • Removed tests from .eslintignore

helper.js

**.cypress.js

  • Re-wrote logic around setting Font Sizes for cross-version compatibility.
  • Adjusted functions to pass the appropriate slug.
    • IE helpers.addCoBlocksBlockToPage( true ); changed to helpers.addCoBlocksBlockToPage( true, 'accordion' );

@AnthonyLedesma AnthonyLedesma added [Type] Enhancement Something new that adds functionality gutenberg plugin labels Jan 15, 2020
@AnthonyLedesma AnthonyLedesma self-assigned this Jan 15, 2020
@richtabor richtabor removed their request for review January 15, 2020 20:28
Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @AnthonyLedesma 👏! Things look good to me, are still working well on my end and tests are all passing.

@EvanHerman EvanHerman merged commit b814575 into master Jan 22, 2020
@EvanHerman EvanHerman deleted the e2e-refactor branch January 22, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Something new that adds functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants