Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CoBlocks Lightbox to remove jQuery #1429

Merged
merged 5 commits into from
Apr 16, 2020
Merged

Refactor CoBlocks Lightbox to remove jQuery #1429

merged 5 commits into from
Apr 16, 2020

Conversation

AnthonyLedesma
Copy link
Member

@AnthonyLedesma AnthonyLedesma commented Mar 20, 2020 •
edited
Loading

Description

Remove all references to jQuery from the CoBlocks Lightbox utility but preserve all functionality.
This PR brings CoBlocks a step closer to achieving #1365.

Types of changes

Code Quality changes to the CoBlocks Lightbox.

How has this been tested?

Tested in Chrome, Firefox, and Edge.

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@AnthonyLedesma AnthonyLedesma added [Type] Code Quality Relevant to improving the quality of our code [Status] Needs Review Tracking pull requests that need another set of eyes labels Mar 20, 2020
@AnthonyLedesma AnthonyLedesma self-assigned this Mar 20, 2020
@AnthonyLedesma AnthonyLedesma marked this pull request as ready for review March 20, 2020 14:46
@AnthonyLedesma AnthonyLedesma mentioned this pull request Mar 20, 2020
Closed
16 tasks
@richtabor

This comment has been minimized.

Sign in to view
@AnthonyLedesma
Copy link
Member Author

@richtabor Fixed that issue you found. Would you re-review when you have time?

@cypress
Copy link

cypress bot commented Mar 27, 2020


Test summary

42 • 0 • 0 • 0

Run details
Project CoBlocks
Status Passed
Commit b11d7c4
Started Mar 27, 2020 5:52 PM
Ended Mar 27, 2020 5:54 PM
Duration 02:16 💡
OS Linux Debian - 10.3
Browser Chrome 80

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@richtabor richtabor merged commit 6efb478 into master Apr 16, 2020
@richtabor richtabor deleted the remove/jquery-2 branch April 16, 2020 20:25
@richtabor richtabor added this to the Next Release milestone Apr 16, 2020
@jrtashjian jrtashjian modified the milestones: Next Release, 1.25.0 Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHerman EvanHerman Awaiting requested review from EvanHerman

@jrtashjian jrtashjian Awaiting requested review from jrtashjian

@richtabor richtabor Awaiting requested review from richtabor

Assignees

@AnthonyLedesma AnthonyLedesma

Labels
[Status] Needs Review Tracking pull requests that need another set of eyes [Type] Code Quality Relevant to improving the quality of our code
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AnthonyLedesma @richtabor @jrtashjian