Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce validation-coding-standards.yml #2452

Merged
merged 18 commits into from
Dec 2, 2022

Conversation

EvanHerman
Copy link
Contributor

Description

Introduce validation-coding-standards.yml workflow file for linting PHP, CSS and JS files.

Types of changes

New feature (non-breaking change which adds functionality)

Acceptance criteria

Add github actions workflow to lint PHP, CSS and JS files.

Checklist:

  • I've added proper labels to this pull request

@EvanHerman EvanHerman added the [Type] Enhancement Something new that adds functionality label Nov 29, 2022
@EvanHerman EvanHerman self-assigned this Nov 29, 2022
@EvanHerman EvanHerman changed the base branch from feature/github-actions-migration to master November 29, 2022 18:41
@EvanHerman EvanHerman marked this pull request as ready for review November 29, 2022 19:06
@kopepasah kopepasah changed the base branch from master to feature/github-actions-migration November 29, 2022 20:47
Copy link
Contributor

@kopepasah kopepasah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments for review.

@EvanHerman EvanHerman requested a review from kopepasah November 30, 2022 19:54
Copy link
Contributor

@kopepasah kopepasah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some additional feedback.

@EvanHerman EvanHerman requested a review from kopepasah December 1, 2022 16:57
Copy link
Contributor

@kopepasah kopepasah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Feel free to merge into the actions migration branch.

@EvanHerman EvanHerman merged commit 9093d2c into feature/github-actions-migration Dec 2, 2022
@EvanHerman EvanHerman deleted the WPEX-2604 branch December 2, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Something new that adds functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants