Make Labs and Settings modals compatible with Gutenberg >=14.3.0 #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2023
AnthonyLedesma
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Excellent changes. Thank you very much for making these changes @WunderBart. Tested and working well.
Thank you, @AnthonyLedesma! 🙌 Do you know if it will land in a patch release anytime soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2474
Description
Fix a regression where the
Editor settingsandCoBlocks Labsmodals render empty for Gutenberg versions >=14.3.0. The breaking change was introduced in WordPress/gutenberg#44642).Types of changes
Bug fix (non-breaking change which fixes an issue)
How has this been tested?
Checkout this branch,
wp-env start && yarn start,Make sure the Gutenberg plugin is not installed (the trunk version is active),
Go to a new post page,
Click the three dots menu in the top right corner,
Click
Editor settingsandCoBlocks Labsand make sure they render correctly,Install and activate the latest Gutenberg plugin (v15.0.1 at the time of writing),
Repeat steps 4-6,
Checkout
masterbranch,Repeat steps 4-6, but now both modals should render broken:
Acceptance criteria
Both modals should be compatible with the latest and trunk version of Gutenberg.