Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with WP 6.4 #2568

Merged
merged 40 commits into from
Oct 31, 2023
Merged

Compatibility with WP 6.4 #2568

merged 40 commits into from
Oct 31, 2023

Conversation

olafleur-godaddy
Copy link
Member

Description

Screenshots

Types of changes

How has this been tested?

Acceptance criteria

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@AnthonyLedesma
Copy link
Member

AnthonyLedesma commented Oct 20, 2023

RichText multiline prop was deprecated. We seem to be using multiline props in a few places. Might need refactors here.
WordPress/gutenberg#54310

Probably related to refactoring:
WordPress/gutenberg#47395

@AnthonyLedesma AnthonyLedesma marked this pull request as ready for review October 31, 2023 14:36
Copy link
Member Author

@olafleur-godaddy olafleur-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

.github/workflows/test-e2e-cypress.yml Outdated Show resolved Hide resolved
.github/workflows/test-e2e.yml Outdated Show resolved Hide resolved
Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A complete test matrix has been established and is passing with these modifications.

https://github.com/godaddy-wordpress/coblocks/actions/runs/6709822699

@AnthonyLedesma
Copy link
Member

I found a quick CSS fix, that I will be pushing up without letting the tests all run again.

@AnthonyLedesma AnthonyLedesma merged commit 37ddad5 into master Oct 31, 2023
11 checks passed
@AnthonyLedesma AnthonyLedesma deleted the WP64-compat branch October 31, 2023 19:34
@AnthonyLedesma AnthonyLedesma added this to the Next Release milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants