Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize the iCal URL before initializing #2607

Merged
merged 6 commits into from
Apr 30, 2024
Merged

Conversation

EvanHerman
Copy link
Contributor

@EvanHerman EvanHerman commented Apr 25, 2024

Description

  • Escape the iCal URL before initializing the events calendar.
  • Prevent localhost or 127.0x URLs from being used for external calendar URLs.

Types of changes

Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Tested by running nc -l 127.0.0.1 9000. Adding a Events block to the page, ticking off Link a calendar and adding the URL http://127.0.0.1:9000 to the calendar URL and ensuring an error is returned.

Checklist:

  • My code is tested
  • I've added proper labels to this pull request

@EvanHerman EvanHerman added the [Type] Bug Something that is not working as expected label Apr 25, 2024
@EvanHerman EvanHerman added this to the Next Release milestone Apr 25, 2024
@EvanHerman EvanHerman self-assigned this Apr 25, 2024
@AnthonyLedesma AnthonyLedesma merged commit b5b5fb7 into master Apr 30, 2024
67 checks passed
@AnthonyLedesma AnthonyLedesma deleted the sanitize-ical-url branch April 30, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something that is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants