added key normalizing #6

azweb76 · 2018-06-27T17:32:19Z

Most applications use client certificates to encrypt/decrypt configuration, however sometimes the certificate contains crlf line endings and in other cases has just lf line endings. This change enables the user to strip whitespace from the key before encrypting/decrypting. This change maintains backward compatibility to not normalize the key. To update the configuration, run convert {key} true true to convert the encrypted data using normalized keys and backup the original values.

asilvas

Great changes!

Asks:

Default to normalize the key during convert
Default to normalize the key when saving a new config (where there were no keys at time of load)

This should squash the issues for good.

asilvas · 2018-07-03T16:32:39Z

scripts/cli.js

  getPrivateKeyPath(privateKeyPath, function (privateKeyPath) {
    getBackup(backup, function (backup) {
      rl.write(': converting...');
-      instance.convert({ privateKeyPath: privateKeyPath, backup: backup === 'true' });
+      instance.convert({ privateKeyPath: privateKeyPath, backup: backup === 'true', normalizeKey: (normalizeKey === 'true' || instance.config._.normalizeKey) });
