Add a new "--scan-filename/--no-scan-filename" flag

[sushantmimani]

To help us get this pull request reviewed and merged quickly, please be sure to include the following items:

• Tests (if applicable)
• Documentation (if applicable)
• Changelog entry
• A full explanation here in the PR description of the work done

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Tests
• Other

Backward Compatibility

Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?

• Yes (backward compatible)
• No (breaking changes)

Issue Linking

Closes #188

What's new?

• This PR adds a new --scan-filename/--no-scan-filename flag which allows user to enable or disable file name scanning using Tartufo.

[tarkatronic]

Thanks for adding this functionality @sushantmimani! As I look at this more, I really can't decide how this should behave; whether it should default to True, default to False, or just always be on. So I've created a discussion to hopefully get some user input on their preferences.

See the discussion here: #262

[tarkatronic]

In addition to the changes noted here, what about scan-folder? Since this is a global option, we need to ensure that it will work across all scanner types.

[mayuriesha]

LGTM

[tarkatronic]

I'm a little concerned that the tests didn't need to be updated for the scan-folder change 😅

Can we make sure that is for reals really working? Is there any kind of unit test we can do for that?

[tarkatronic]

Love it!