Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump for v3.0.0-alpha.1 #280

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Version bump for v3.0.0-alpha.1 #280

merged 2 commits into from
Nov 11, 2021

Conversation

tarkatronic
Copy link
Contributor

This will be the first alpha release of tartufo v3, to give users a taste of what is to come, and to let them help shake out any bugs.

Documentation on new features is sparse still, but I think this could prove a welcome glimpse.

Plus it gives users a chance to make sure they are pinned to a "safe" v2.x version before we get TOO far down this rabbit hole.

@tarkatronic tarkatronic requested a review from a team as a code owner November 11, 2021 17:43
@tarkatronic tarkatronic requested review from janerikcarlsen, sjacoby-godaddy and rbailey-godaddy and removed request for a team November 11, 2021 17:43
Copy link
Contributor

@rbailey-godaddy rbailey-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One initial sanity-check question first...

I'm not so familiar with the python (poetry/pip) versioning ecosystem, but in the rpm world this version would be problematic because 3.0.0-alpha.1 would come lexically AFTER 3.0.0 and we'd have to get to some number higher than 3.0.0 before ordering becomes sane again.

Will this version work the way we intend?

@rbailey-godaddy rbailey-godaddy self-requested a review November 11, 2021 18:12
@tarkatronic tarkatronic merged commit ca46e5c into v3.x Nov 11, 2021
@tarkatronic tarkatronic deleted the release/v3.0.0-alpha.1 branch November 11, 2021 18:14
@tarkatronic
Copy link
Contributor Author

One initial sanity-check question first...

I'm not so familiar with the python (poetry/pip) versioning ecosystem, but in the rpm world this version would be problematic because 3.0.0-alpha.1 would come lexically AFTER 3.0.0 and we'd have to get to some number higher than 3.0.0 before ordering becomes sane again.

Will this version work the way we intend?

For posterity sake, since this got answered in a private conversation, I just wanted to respond that yes! This absolutely works the way we would hope!

Poetry internally uses a -alpha.1 indicator, which then gets translated when the distributable packages are built, to make the final "released" version equal to 3.0.0a1. And this version number, as you can see here on PyPI, is understood to be a pre-release: https://pypi.org/project/tartufo/#history

For anybody interested in more information on the topic...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants