Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing rule-patterns from default configuration files #482

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

emayuri-godaddy
Copy link
Contributor

@emayuri-godaddy emayuri-godaddy commented Mar 30, 2023

To help us get this pull request reviewed and merged quickly, please be sure to include the following items:

  • Tests (if applicable)
  • Documentation (if applicable)
  • Changelog entry
  • A full explanation here in the PR description of the work done

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Backward Compatibility

Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?

  • Yes (backward compatible)
  • No (breaking changes)

Issue Linking

fixes #476

What's new?

  • Processing of rule patterns has not been working correctly after deprecation of --rules. The PR fixes the issue.

@emayuri-godaddy emayuri-godaddy requested a review from a team as a code owner March 30, 2023 16:36
@emayuri-godaddy emayuri-godaddy force-pushed the rule-pattern branch 2 times, most recently from 398d6f6 to 07c4067 Compare March 30, 2023 16:43
@emayuri-godaddy emayuri-godaddy merged commit 345092b into main Apr 3, 2023
@emayuri-godaddy emayuri-godaddy deleted the rule-pattern branch April 3, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tartufo does not process rule-patterns set up in default config file set up in repository being scanned.
3 participants