Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Run example tests from docs #14

Closed
1 task done
JCZuurmond opened this issue Jun 1, 2022 · 0 comments · Fixed by #17
Closed
1 task done

[Feature] Run example tests from docs #14

JCZuurmond opened this issue Jun 1, 2022 · 0 comments · Fixed by #17
Assignees
@JCZuurmond
Labels
enhancement New feature or request
Milestone
0.1.0

Comments

@JCZuurmond
Copy link
Collaborator

JCZuurmond commented Jun 1, 2022 •
edited
Loading

Is this your first time opening an issue?

Describe the Feature

The docs contain example tests, we should verify that those pass.

Note:

  • The examples rely on macros. Where do we keep those? These should be stored in a place so that the tests can use them.

Describe alternatives you've considered

NA

Who will this benefit?

Me, as package maintainer I want to make sure that the examples in docs are accurate

Are you interested in contributing this feature?

yes

Anything else?

No response
@JCZuurmond JCZuurmond added the enhancement New feature or request label Jun 1, 2022
@JCZuurmond JCZuurmond self-assigned this Jun 1, 2022
@JCZuurmond JCZuurmond added this to the 0.1.0 milestone Jun 1, 2022
@JCZuurmond JCZuurmond changed the title [Feature] Use doctest to test examples in docs [Feature] Run example tests from docs Jun 1, 2022
@JCZuurmond JCZuurmond mentioned this issue Jun 1, 2022
Merged
4 tasks
JCZuurmond added a commit that referenced this issue Jul 22, 2022
@JCZuurmond
Release 0.1.0
ece291f 
- Run test examples from docs ([issue](#14), [PR](#17))
- Add target flag ([issue](#11), [PR](#13))
- Delete session module [is included in dbt-spark](dbt-labs/dbt-spark#272)
- Add Github templates
@JCZuurmond JCZuurmond mentioned this issue Jul 22, 2022
Merged
JCZuurmond added a commit that referenced this issue Jul 22, 2022
@JCZuurmond
Release 0.1.0 (#18)
f02cef3 
- Run test examples from docs ([issue](#14), [PR](#17))
- Add target flag ([issue](#11), [PR](#13))
- Delete session module [is included in dbt-spark](dbt-labs/dbt-spark#272)
- Add Github templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JCZuurmond JCZuurmond

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Run test examples from docs godatadriven/pytest-dbt-core
1 participant
@JCZuurmond