Update 4_first_run.rst #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidied up to be easier to understand.
elvisish
requested review from
StraToN,
BHSDuncan,
dploeger and
balloonpopper
as code owners
BHSDuncan
reviewed
May 14, 2022
StraToN
approved these changes
Jul 5, 2022
|
What is the status on this? There are some doc8 checks failing (most probably trailing empty spaces). |
|
By the look of it, the suggestion I made to clear up the confusion hasn't been accepted or rejected, so I'm not sure what's happening with that. After that, the doc8 failure would need to be fixed. |
|
@elvisish care to update us on this? |
You need to commit/accept @balloonpopper 's suggestion above. That's what he was referring to--not the overall PR. |
Co-authored-by: balloonpopper <5151242+balloonpopper@users.noreply.github.com>
|
No updates for a long time. I updated the branch locally and created a new PR #76 that supersedes this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made it slightly easier to understand