Squash the creeps branch #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the "squash-the-creeps" project to the Cargo workspace, enabling it to be built and managed alongside other projects in the workspace.
The paths to the Rust libraries were modified to reflect the new directory structure, ensuring the correct binaries are linked during the build process.
The Input class is now imported to manage user input more effectively, ensuring smoother interaction handling in the player module. The deletion of the cheatseet.txt file removes outdated guidelines, as they are no longer relevant to the current codebase.
The mob_scene field in MainScene has been modified to use OnEditor instead of OnReady. This change allows the scene to be set via the editor, improving flexibility and maintainability.
Update the comment in `main_scene.rs` to match the correct syntax for exporting a `PackedScene`. Remove redundant initialization code in `scorelabel.rs` by using the `#[class(init)]` attribute instead of manually implementing the `init` method.
Removed manual initialization code in Mob and Player structs by leveraging the #[init] attribute for default values. This improves code maintainability and reduces redundancy. Also removed unnecessary bind parameters in the mob squashed signal connection.
The `min_speed` and `max_speed` fields in the `Mob` struct are now exported, allowing for easier configuration in the Godot editor. Additionally, the transform of the Character node in the mob.tscn file has been adjusted for better alignment.
…d player modules This commit refactors the code by adding consistent spacing and improving readability in the `main_scene`, `mob`, and `player` modules. The changes include adding line breaks for better visual separation of code blocks and ensuring consistent formatting. No functional changes were made.
Exported player properties such as speed, jump_impulse, bounce_impulse, fall_acceleration, and target_velocity to allow for easier configuration and customization through the Godot editor. This change improves maintainability and flexibility without altering the player's behavior.
…ions This commit introduces additional input events for joystick and mouse controls, enhancing the game's accessibility and providing more options for player input. The changes include support for joystick motions and mouse button events alongside the existing keyboard inputs.
Add min_speed and max_speed to mob.tscn, speed, jump_impulse, bounce_impulse, and fall_acceleration to player.tscn. Update mob_scene and physics_interpolation_mode in main.tscn. Adjust paths in RustScripts.gdextension for consistency.
…nction Add a detailed TODO comment explaining the error encountered when the `on_mob_timer_timeout` function is called. The error involves accessing a freed instance, causing a panic. This comment serves as a placeholder for future debugging and fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
separate branch with new changes