Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ToGodot and FromGodot conversions use Result #451

Closed
lilizoey opened this issue Oct 14, 2023 · 0 comments · Fixed by #467
Closed

Make ToGodot and FromGodot conversions use Result #451

lilizoey opened this issue Oct 14, 2023 · 0 comments · Fixed by #467
Assignees
Labels
c: register Register classes, functions and other symbols to GDScript feature Adds functionality to the library

Comments

@lilizoey
Copy link
Member

In #421 we created a unified api for converting types across ffi. However every ToGodot conversion was assumed infallible, and FromGodot uses Option<T> to signal fallibility. This was to limit the scope of that PR, but means that error reporting isn't as good as it could be. It likely also meant a small regression is error messages.

We should change these to use Result instead to be able to handle errors better and with better error messaging.

@lilizoey lilizoey added feature Adds functionality to the library c: register Register classes, functions and other symbols to GDScript labels Oct 14, 2023
@lilizoey lilizoey self-assigned this Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: register Register classes, functions and other symbols to GDScript feature Adds functionality to the library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant