Catch null object pointers in Variant::is_nil #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With varcall, Godot sometimes return null objects as Variants with `VariantType::Object` but a null pointer, instead of the usually expected/assumed `VariantType::Nil`. This caused `Option::from_variant` to panic in case of null objects returned by Godot in this way. Fix godot-rust#1001
chitoyuu
added
bug
c: core
|
bors try |
tryBuild succeeded: |
|
bors r+ |
|
Build succeeded: |
chitoyuu
added a commit
to chitoyuu/godot-rust
that referenced
this pull request
Jan 21, 2023
As of godot-rust#1002, it has been discovered that more than one representations for Nil can exist, and such tests should be carried out using `is_nil()` instead.
bors bot
added a commit
that referenced
this pull request
Jan 21, 2023
1012: Fix FromVariant impls using get_type to test for Nils r=chitoyuu a=chitoyuu As of #1002, it has been discovered that more than one representations for Nil can exist, and such tests should be carried out using `is_nil()` instead. Co-authored-by: Chitose Yuuzaki <chitoyuu@potatoes.gay>
chitoyuu
added a commit
to chitoyuu/godot-rust
that referenced
this pull request
Jan 23, 2023
Without the flag, Godot will not emit "Leaked instance" messages we're looking for in CI. The leak was introduced in godot-rust#1002, in the `test_nil_object_return_value` test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With varcall, Godot sometimes return null objects as Variants with
VariantType::Objectbut a null pointer, instead of the usually expected/assumedVariantType::Nil. This causedOption::from_variantto panic in case of null objects returned by Godot in this way.Fix #1001